Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0050] VM Syscalls 3 #418

Merged

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Apr 22, 2023

@zhangsoledad zhangsoledad force-pushed the zhangsoledad/vm-syscalls branch 2 times, most recently from 951e1a2 to ba75d91 Compare May 11, 2023 08:21
This was referenced Jun 16, 2023
@zhangsoledad zhangsoledad changed the title VM Syscalls 3 [0050] VM Syscalls 3 Jun 16, 2023
@zhangsoledad zhangsoledad marked this pull request as ready for review June 16, 2023 08:58
@zhangsoledad zhangsoledad requested a review from a team as a code owner June 16, 2023 08:58
rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Outdated Show resolved Hide resolved
rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Outdated Show resolved Hide resolved
Co-authored-by: xjd <lynndon@gmail.com>
Copy link
Contributor

@yangby-cryptape yangby-cryptape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understood correctly, all M in this RFC means $2^{20}$; strictly speaking, they should be Mi.

According to "ISO/IEC 80000":

  • M is "mega", it's a metric prefix, it means $10^{6}$.
  • To represent $2^{20}$, IEC prefix Mi should be used, it's short for "mebi", defined in "IEC 60027-2".

rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Outdated Show resolved Hide resolved
rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Outdated Show resolved Hide resolved
rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Outdated Show resolved Hide resolved
rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Outdated Show resolved Hide resolved
rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Outdated Show resolved Hide resolved
rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Outdated Show resolved Hide resolved
rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Outdated Show resolved Hide resolved
@mohanson
Copy link
Contributor

mohanson commented Jul 10, 2023

Please add the introduction of Current Memory syscall

Current Memory

Get the Current Memory Usage. The result is the sum of the memory usage of the parent script and the child script.

int ckb_current_memory();

The system call returns an integer. Multiply it by 0.5 to get the actual memory usage (unit: megabytes)

zhangsoledad and others added 2 commits July 10, 2023 15:48
@zhangsoledad
Copy link
Member Author

zhangsoledad commented Jul 10, 2023

Please add the introduction of Current Memory syscall

Current Memory

Get the Current Memory Usage. The result is the sum of the memory usage of the parent script and the child script.

int ckb_current_memory();

The system call returns an integer. Multiply it by 0.5 to get the actual memory usage (unit: megabytes)

Already added, please review

XuJiandong
XuJiandong previously approved these changes Nov 6, 2023
@zhangsoledad zhangsoledad merged commit d6ff98f into nervosnetwork:master Jan 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants