Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ckb 2023 edition #3917

Merged
merged 31 commits into from
May 23, 2023
Merged

ckb 2023 edition #3917

merged 31 commits into from
May 23, 2023

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Mar 29, 2023 •
edited
Loading

What problem does this PR solve?

The complete implementation of ckb2023 contains the following parts:

  1. hardfork deployment
  2. vm upgrade
  3. new syscall implementation
  4. remove the reservation rule of header version field

Related rfcs:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad added b:consensus Break consensus u:ckb2023 Upgrade: Fork ckb2023 labels Mar 30, 2023
@zhangsoledad zhangsoledad added this to the ckb2023 milestone Mar 30, 2023
@zhangsoledad zhangsoledad self-assigned this Mar 30, 2023
@zhangsoledad zhangsoledad force-pushed the ckb2023 branch 2 times, most recently from a5e0ba1 to 0281179 Compare April 7, 2023 08:01
@zhangsoledad zhangsoledad force-pushed the ckb2023 branch 2 times, most recently from 9759c01 to 932a16f Compare April 24, 2023 12:30
@zhangsoledad zhangsoledad force-pushed the ckb2023 branch 2 times, most recently from d4ae25c to cd27b5e Compare May 8, 2023 01:32
eval-exec
eval-exec reviewed May 10, 2023
View reviewed changes
script/src/types.rs Outdated Show resolved Hide resolved
@zhangsoledad zhangsoledad requested a review from a team as a code owner May 16, 2023 07:02
@zhangsoledad zhangsoledad requested review from quake and a team and removed request for a team May 16, 2023 07:02
@zhangsoledad zhangsoledad mentioned this pull request May 17, 2023
Closed
quake
quake reviewed May 19, 2023
View reviewed changes
script/src/syscalls/spawn.rs Outdated Show resolved Hide resolved
quake
quake reviewed May 19, 2023
View reviewed changes
script/src/syscalls/utils.rs Show resolved Hide resolved
script/src/syscalls/spawn.rs Show resolved Hide resolved
@zhangsoledad zhangsoledad added this pull request to the merge queue May 23, 2023
Merged via the queue into develop with commit fdee47b May 23, 2023
@nervos-bot-user nervos-bot-user mentioned this pull request May 23, 2023
Closed
@doitian doitian mentioned this pull request Jun 13, 2023
Closed
This was referenced Aug 1, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@quake quake Awaiting requested review from quake

@mohanson mohanson Awaiting requested review from mohanson

@driftluo driftluo Awaiting requested review from driftluo

Assignees

@zhangsoledad zhangsoledad

Labels
b:consensus Break consensus u:ckb2023 Upgrade: Fork ckb2023
Projects
CKB Kanban
Archived in project
Milestone
ckb2023
Development

Successfully merging this pull request may close these issues.
5 participants
@zhangsoledad @quake @mohanson @driftluo @eval-exec