Update 0022-transaction-structure.md #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add Appendix B and C containing syscalls and constants.
|
I would suggest creating a new RFC for these contents, since they are not relevant to RFC22. See the Process in the README about how to create a new RFC. It's better to add bidirectional links as well.
|
doitian
reviewed
Jul 12, 2023
| @@ -402,3 +402,78 @@ Cell data hash is just `ckbhash(data)`. | |||
|
|
|||
| Script hash is `ckbhash(molecule_encode(script))` where `molecule_encode` turns the script structure into a block of binary via molecule. See the definition `Script` in the [schema file](https://github.com/nervosnetwork/ckb/blob/a6733e6af5bb0da7e34fb99ddf98b03054fa9d4a/util/types/schemas/blockchain.mol#L28-L32). | |||
|
|
|||
| ## Appendix B: Syscalls | |||
|
|
|||
| | VM Ver. | Syscall ID | C Function Name | Description | Return Value | Partial Loading[^2] | 1st Arg | 2nd Arg | 3rd Arg | 4th Arg | 5th Arg | 6th Arg | C Example | | |||
There was a problem hiding this comment.
There are too many columns, making the viewing experience on GitHub really bad.
My suggestion is removing most columns and adding links to their detailed documentations.
| VM Ver. | Syscall ID | C Function Name | Description |
| --- | --- | --- | --- |
| 1 | 93 | [ckb_exit][] | terminate execution with the specified return code |
[ckb_exit]: https://github.com/nervosnetwork/rfcs/blob/master/rfcs/0009-vm-syscalls/0009-vm-syscalls.md#exit
which gives us:
| VM Ver. | Syscall ID | C Function Name | Description |
|---|---|---|---|
| 1 | 93 | ckb_exit | terminate execution with the specified return code |
There was a problem hiding this comment.
Drafting new RFC based on the comments. One question, is the new RFC solely about vm syscalls? Or, Appendix C: Constants will still be included?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Appendix B and C containing tables of syscalls and constants.