Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on vlan reservation and add backward compatibility to Port.label_range #207

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

italovalcy
Copy link
Contributor

Fix #200

Heads-UP: this PR depends on atlanticwave-sdx/datamodel#141

Description of the change

  • VLAN reservation routine had a bug where if the user requests a VLAN which is not on the VLAN table (meaning: the OXP does not specify that VLAN on their allowed range -- which by the way should be discussed), the TEManager._reserve_vlan call would fail with KeyError when running unit test:
FAILED tests/test_te_manager.py::TEManagerTests::test_connection_amlight_to_zaoxi_user_port_v2 - KeyError: 777
  • Added backward compatibility to Port.label_range (also handled on datamodel PortHandler)

pyproject.toml Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Aug 10, 2024

Pull Request Test Coverage Report for Build 10350365886

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 85.956%

Totals Coverage Status
Change from base Build 10271724419: 0.7%
Covered Lines: 1108
Relevant Lines: 1267

💛 - Coveralls

pyproject.toml Outdated Show resolved Hide resolved
@italovalcy italovalcy merged commit 7346650 into main Aug 12, 2024
11 checks passed
@italovalcy italovalcy deleted the fix/issue_200 branch August 12, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test suite is broken
3 participants