Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add means to calculate failed links on the topology #211

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

italovalcy
Copy link
Contributor

@italovalcy italovalcy commented Aug 10, 2024

Related to atlanticwave-sdx/sdx-controller#161

Heads-Up: sits on top of the other in-flight pull requests (#207 and #209 and #210)

Description of the change

Basically adds a function which returns the failed links to be used after the topology update and help identify connections to be redeployed (atlanticwave-sdx/sdx-controller#161)

@italovalcy italovalcy requested review from sajith, YufengXin and congwang09 and removed request for sajith and YufengXin August 10, 2024 12:12
Copy link
Member

@sajith sajith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from fix/issue_203 to main August 12, 2024 11:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10350902433

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 86.265%

Totals Coverage Status
Change from base Build 10350837399: 0.1%
Covered Lines: 1121
Relevant Lines: 1279

💛 - Coveralls

@italovalcy italovalcy merged commit 8f2714c into main Aug 12, 2024
11 checks passed
@italovalcy italovalcy deleted the fix/issue_controller_161 branch August 12, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants