Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Link.bandwidth to interdomain Links based on ports type #209

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

italovalcy
Copy link
Contributor

Fix #201

Heads-Up: This PR sits on top of #207 -- it turns out the main branch was failing as documented on issue #200

Heads-up1: this PR sits on top of atlanticwave-sdx/datamodel#140 (merged)

Description of the change

This pull request adds Links.bandwidth to inter domain Links based on Port's type.

Copy link
Member

@sajith sajith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks!

Base automatically changed from fix/issue_200 to main August 12, 2024 11:06
@italovalcy italovalcy merged commit 22c2f98 into main Aug 12, 2024
10 checks passed
@italovalcy italovalcy deleted the fix/issue_201 branch August 12, 2024 11:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10350778437

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 85.964%

Totals Coverage Status
Change from base Build 10350702735: 0.008%
Covered Lines: 1109
Relevant Lines: 1268

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper update inter-domain Link speed
3 participants