-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto detect port from Dockerfile #4454
Auto detect port from Dockerfile #4454
Conversation
Hi, @saragluna , @weikanglim , @puicchan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rujche Thanks for getting this started! I left two blocking comments:
- Move the logic into
appdetect
and surface metadata that way - Make sure to handle the full EXPOSE syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rujche ! This is looking better, thanks for adopting the suggestion to move the detection logic into appdetect
package.
I left some comments for the next review iteration.
…ect) with the multiple ports available, and an "Other" selection to provide the port number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rujche Love the great progress here! I left a few more comments based on what I noticed, but I think we're really close.
I'm really happy with how much we have simplified the implementation -- it looks a lot cleaner!
…rviceSpec.Port by svc.Docker.Ports.
Hi, @weikanglim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks really good! Narrowed it down a few more comments to address. We are getting real close!
Hi, @weikanglim |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, @rujche! Thank you for taking the time to address all the comments.
I do really like how the final change looks like. It's very clean and feature rich. I think our users are going to love this feature addition!
Thank you!
I like the attention to detail here, even when dealing with multiple ports:
@weikanglim |
Resolve #4443
Auto detect port from Dockerfile