Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto detect port from Dockerfile #4454

Merged
merged 28 commits into from
Oct 23, 2024
Merged

Auto detect port from Dockerfile #4454

merged 28 commits into from
Oct 23, 2024

Commits on Oct 17, 2024

  1. Implement feature: detect port in Dockerfile.

    @rujche
    rujche committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    8707673 View commit details
    Browse the repository at this point in the history

  2. Set port when there is only one port detected in Dockerfile.

    @rujche
    rujche committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    62f3754 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Move the logic into appdetect and surface metadata that way

    @rujche
    rujche committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    90686c6 View commit details
    Browse the repository at this point in the history

  2. Make sure to handle the full EXPOSE syntax.

    @rujche
    rujche committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4eb90e7 View commit details
    Browse the repository at this point in the history

  3. Fix error: the line length exceeds the maximum of 125 characters.

    @rujche
    rujche committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d189c9b View commit details
    Browse the repository at this point in the history

  4. Fix test failure of TestDetectDocker.

    @rujche
    rujche committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6b88907 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. Move Docker from docker.go to appdetect.go.

    @rujche
    rujche committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    1c5f209 View commit details
    Browse the repository at this point in the history

  2. Improve this function: getExposedPorts.

    @rujche
    rujche committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    01a2e3b View commit details
    Browse the repository at this point in the history

  3. Introduce a new struct: Port.

    @rujche
    rujche committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    52f39cc View commit details
    Browse the repository at this point in the history

  4. Propagate the error returned from parsePorts.

    @rujche
    rujche committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    f5f12f5 View commit details
    Browse the repository at this point in the history

  5. If more than one port is exposed, prompt for a selection (console.Sel… 

    …ect) with the multiple ports available, and an "Other" selection to provide the port number.
    @rujche
    rujche committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    f2535d2 View commit details
    Browse the repository at this point in the history

  6. Update TestParsePorts.

    @rujche
    rujche committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    d2fa167 View commit details
    Browse the repository at this point in the history

  7. Fix test failure.

    @rujche
    rujche committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    5823bc3 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Use strings.Fields to replace strings.Split.

    @rujche
    rujche committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    663d6e9 View commit details
    Browse the repository at this point in the history

  2. Add some context to the error about port number parsing.

    @rujche
    rujche committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    08fbcfa View commit details
    Browse the repository at this point in the history

  3. Add some context to the error about port number parsing.

    @rujche
    rujche committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f8a86df View commit details
    Browse the repository at this point in the history

  4. Not return error when fail to parse EXPOSE

    @rujche
    rujche committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    594961e View commit details
    Browse the repository at this point in the history

  5. Trim space for each line in Dockerfile.

    @rujche
    rujche committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4307fe1 View commit details
    Browse the repository at this point in the history

  6. Add context to the error.

    @rujche
    rujche committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ee5654a View commit details
    Browse the repository at this point in the history

  7. Add "assert.NoError(t, err)" for extra validation.

    @rujche
    rujche committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e79b95d View commit details
    Browse the repository at this point in the history

  8. Rename "parsePorts" to "parsePortsInLine"

    @rujche
    rujche committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    28686a4 View commit details
    Browse the repository at this point in the history

  9. Add function of "parsePortsInFile" and related unit test.

    @rujche
    rujche committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1128295 View commit details
    Browse the repository at this point in the history

  10. Add function of "getPortByPrompt" and improve the logic of getting se… 

    …rviceSpec.Port by svc.Docker.Ports.
    @rujche
    rujche committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6675fc7 View commit details
    Browse the repository at this point in the history

  11. Fix typo: "pors" -> "ports".

    @rujche
    rujche committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    2fb64fd View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Use different prompt message for 0 port detected and multiple ports d… 

    …etected.
    @rujche
    rujche committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b9cdded View commit details
    Browse the repository at this point in the history

  2. Use string instead of files to test.

    @rujche
    rujche committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    12ae5b1 View commit details
    Browse the repository at this point in the history

  3. Change "parsePortsInFile" to "detectDockerFromFile".

    @rujche
    rujche committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    88cb3e7 View commit details
    Browse the repository at this point in the history

  4. Remove duplicated code in parsePortsInLine.

    @rujche
    rujche committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1067b04 View commit details
    Browse the repository at this point in the history