Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

easy-init: azd should auto detect port from Dockerfile #4443

Closed
weikanglim opened this issue Oct 16, 2024 · 1 comment · Fixed by #4454
Closed

easy-init: azd should auto detect port from Dockerfile #4443

weikanglim opened this issue Oct 16, 2024 · 1 comment · Fixed by #4454
Assignees
@weikanglim @saragluna @rujche
Labels
easy-init enhancement
Milestone
Nov 2024

Comments

@weikanglim
Copy link
Contributor

weikanglim commented Oct 16, 2024 •
edited
Loading

After discussion with @puicchan:

  1. Look in Dockerfile
  2. If EXPOSE with single port is found, use it and don't ask
  3. If EXPOSE is not found, ask the customer.
  4. If more than one port is exposed, prompt for a selection (console.Select) with the multiple ports available, and an "Other" selection to provide the port number.

Multiple ports example:

Select a port number:
- 5050 
- 8080
- Other
@weikanglim weikanglim added this to the Nov 2024 milestone Oct 16, 2024
@rujche rujche self-assigned this Oct 17, 2024
@rujche
Copy link
Member

rujche commented Oct 17, 2024

FYI:

  1. PR is coming soon, and the PR is targeting to main branch.
  2. Reference PR: https://github.com/saragluna/azure-dev/pull/10/files

@rujche rujche linked a pull request Oct 17, 2024 that will close this issue
Auto detect port from Dockerfile #4454
Merged
@rujche rujche mentioned this issue Oct 17, 2024
Merged
weikanglim pushed a commit that referenced this issue Oct 23, 2024
@rujche
easy-init: auto detect port from Dockerfile (#4454)
aa34833 
Use the `EXPOSE` directives in a Dockerfile to default the port configuration for the service. 

- When multiple `EXPOSE` ports are present, we will prompt the user for port selection.
- When no Dockerfile or `EXPOSE` is present, the user will be asked as usual to provide a port number.

Completes #4443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weikanglim weikanglim

@saragluna saragluna

@rujche rujche

Labels
easy-init enhancement
Projects
None yet
Milestone
Nov 2024
Development

Successfully merging a pull request may close this issue.

Auto detect port from Dockerfile rujche/azure-dev
3 participants
@weikanglim @saragluna @rujche