Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modern-module): use module style export for non entry module #7996

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

fi3ework
Copy link
Member

Summary

  • If the variable to be exported is not in the inlined module (commonly triggered by async modules), should use the "module" style export way to export it.
  • Deleted the test cases of library in rspack test which are duplicated with existing webpack test.
  • Remove -- from testu command, I do not know when it became redundant and will fail the command.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Sep 26, 2024
Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit d662b42
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66f5517fa79cfa0008728149
😎 Deploy Preview https://deploy-preview-7996--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LingyuCoder
Copy link
Collaborator

The -- -u in testu works well for me. It only works when using npm run testu. If you use pnpm run testu, the -- will be converted to "--" and then the test will regard it as a path and run without any test cases. Perhaps we can use a bash script for compatibility.

@fi3ework
Copy link
Member Author

The -- -u in testu works well for me. It only works when using npm run testu. If you use pnpm run testu, the -- will be converted to "--" and then the test will regard it as a path and run without any test cases. Perhaps we can use a bash script for compatibility.

The newer version (6.2.1, we're using 6.2.0) of npm-run-all2 has fix the -- dilemma https://redirect.github.com/bcomnes/npm-run-all2/pull/143. I'll launch a new PR to fix this. Revert the change in this PR.

@fi3ework fi3ework merged commit 8b80b6f into web-infra-dev:main Sep 26, 2024
28 checks passed
@fi3ework fi3ework deleted the export-non-inline branch September 26, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants