chore: drop npm-run-all, make command npm client agnostic #8005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
LingyuCoder
reviewed
Sep 27, 2024
This reverts commit 757de0d.
LingyuCoder
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ref: #7996 (comment)
npm-run-all2, use pnpm run commandnpm run testandpnpm run testwork finenpm run test -- xxxandpnpm run test -- xxxworks finenpm-run-all2. In fact, these commands cannot be executed at all because npm-run-all2 is not installed, so I think these commands are obsolete.with pnpm's
--streamflag, the log will be easier to be read:Checklist