Make theme default to system on initial launch on iOS #7802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BijinDev
force-pushed
the
7045-ios-system-theme
branch
from
9109192
to
8c563d7
Compare
10 tasks
charlag
reviewed
Oct 24, 2024
wrdhub
approved these changes
Oct 24, 2024
tutao-mac
force-pushed
the
7045-ios-system-theme
branch
from
8c563d7
to
4efde45
Compare
On iOS the app defaults to light theme on initial launch, even if the system theme is dark. This is a result of iOS initialUrl not containing a theme param causing it to miss initial theme setting logic branch. Co-authored-by: hrb-hub <181954414+hrb-hub@users.noreply.github.com> Close: #7045
BijinDev
force-pushed
the
7045-ios-system-theme
branch
from
4efde45
to
aef65f4
Compare
Whitelabel smoke tested and commit message updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS the app defaults to light theme on initial launch, even if the system theme is dark.
This is a result of iOS initialUrl not containing a theme param causing it to miss initial theme setting logic branch.
Co-authored-by: hrb-hub 181954414+hrb-hub@users.noreply.github.com
Close: #7045