Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When first installed, iOS app does not respect System theme #7045

Open
10 tasks
wrdhub opened this issue May 31, 2024 · 0 comments · May be fixed by #7802
Open
10 tasks

When first installed, iOS app does not respect System theme #7045

wrdhub opened this issue May 31, 2024 · 0 comments · May be fixed by #7802
Assignees
@BijinDev
Labels
bug broken functionality, usability problems, unexpected errors ios issues that concern the ios client but not all clients

Comments

@wrdhub
Copy link
Contributor

wrdhub commented May 31, 2024 •
edited by hrb-hub
Loading

When first installing the app, "System" is automatically selected for the "Switch color theme" setting, the used color theme does not match. It always uses Light theme.

Should:

  • Match System theme when first opening app and logging in

Test Notes

  • Make sure app is not installed.
  • Set system theme to dark and install the app.
  • Launch the app, theme should match the system. Meaning switching system theme to light would reflect in the app.
  • Change the application theme, close and reopen the app to make sure the newly chosen theme is applied regardless of system theme.
  • White label should still work correctly
  • Clients
    • iOS
    • Android
    • Web
    • Desktop

Actual time= 5.5hrs
@wrdhub wrdhub added bug broken functionality, usability problems, unexpected errors ios issues that concern the ios client but not all clients labels May 31, 2024
@BijinDev BijinDev self-assigned this Oct 23, 2024
BijinDev added a commit that referenced this issue Oct 23, 2024
@BijinDev
Make theme default to system on initial launch on iOS
9109192 
Co-authored-by: hrb-hub <181954414+hrb-hub@users.noreply.github.com>

Close: #7045
@BijinDev BijinDev linked a pull request Oct 23, 2024 that will close this issue
Open
BijinDev added a commit that referenced this issue Oct 23, 2024
@BijinDev
Make theme default to system on initial launch on iOS
8c563d7 
Co-authored-by: hrb-hub <181954414+hrb-hub@users.noreply.github.com>

Close: #7045
@BijinDev BijinDev linked a pull request Oct 23, 2024 that will close this issue
Make theme default to system on initial launch on iOS #7802
Open
tutao-mac pushed a commit that referenced this issue Oct 25, 2024
@BijinDev
Make theme default to system on initial launch on iOS
4efde45 
Co-authored-by: hrb-hub <181954414+hrb-hub@users.noreply.github.com>

Close: #7045
BijinDev added a commit that referenced this issue Oct 25, 2024
@BijinDev
Make theme default to system on initial launch on iOS
aef65f4 
On iOS the app defaults to light theme on initial launch,
even if the system theme is dark.

This is a result of iOS initialUrl not containing a theme param causing
it to miss initial theme setting logic branch.

Co-authored-by: hrb-hub <181954414+hrb-hub@users.noreply.github.com>

Close: #7045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BijinDev BijinDev

Labels
bug broken functionality, usability problems, unexpected errors ios issues that concern the ios client but not all clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make theme default to system on initial launch on iOS tutao/tutanota
2 participants
@wrdhub @BijinDev