Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contact selection issues #7358

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Fix contact selection issues #7358

merged 1 commit into from
Aug 9, 2024

Commits on Aug 9, 2024

  1. Fix contact selection issues

    This is another spin on solving #7256.
    
    This reverts 5be8367 and 26dfa0f as they introduced some
    issues with initialization, namely `initOnce` could run
    multiple times.
    
    In this commit we try to acknowledge that existing URL pattern is not
    sufficient to distinguish between the cases as we might have selection
    without focus.
    
    Instead, we introduce an explicit argument to focus the item details.
    
    We considered synchronizing the column focus state using this argument
    in all cases but this would entail a larger refactoring.
    charlag authored and wec43 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    6226e69 View commit details
    Browse the repository at this point in the history