Fix contact selection issues #7358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paw-hub
reviewed
Aug 9, 2024
Comment on lines
72
to
74
| this.targetContactId != null | ||
| ? this.targetContactId | ||
| : !this.listModel.state.inMultiselect && this.listModel.getSelectedAsArray().length === 1 |
There was a problem hiding this comment.
Would nullish coalescing ?? not work here?
There was a problem hiding this comment.
it would! I'll change it
charlag
force-pushed
the
fix-contact-focus-7256
branch
2 times, most recently
from
61a5a77
to
39319d7
Compare
|
rebased |
paw-hub
approved these changes
Aug 9, 2024
This is another spin on solving #7256. This reverts 5be8367 and 26dfa0f as they introduced some issues with initialization, namely `initOnce` could run multiple times. In this commit we try to acknowledge that existing URL pattern is not sufficient to distinguish between the cases as we might have selection without focus. Instead, we introduce an explicit argument to focus the item details. We considered synchronizing the column focus state using this argument in all cases but this would entail a larger refactoring.
wec43
force-pushed
the
fix-contact-focus-7256
branch
from
39319d7
to
6226e69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another spin on solving #7256.
This reverts 5be8367 and 26dfa0f as they introduced some issues with initialization, namely
initOncecould run multiple times.In this commit we try to acknowledge that existing URL pattern is not sufficient to distinguish between the cases as we might have selection without focus.
Instead, we introduce an explicit argument to focus the item details.
We considered synchronizing the column focus state using this argument in all cases but this would entail a larger refactoring.