Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace obsolete File.exists? with File.exist? #259

Closed
wants to merge 1 commit into from

Conversation

ashie
Copy link
Contributor

@ashie ashie commented Feb 3, 2023

File.exists? has been removed as of Ruby 3.2:
https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/

@ashie ashie requested a review from a team as a code owner February 3, 2023 05:08
@tung-vu-td
Copy link
Contributor

Thank you very much @ashie for this PR 🙇 . I included the changed in #260 in order to add test for ruby 3.2. So I will close this PR.

@tung-vu-td tung-vu-td closed this Feb 8, 2023
@ashie ashie deleted the replace-file_exists branch February 8, 2023 05:37
@ashie
Copy link
Contributor Author

ashie commented Feb 24, 2023

@tung-vu-td

BTW do you have any plan to release new td gem which support Ruby 3.2?
We are developing the next version of td-agent (the name will be changed to fluentd-package or something) which will bundle Ruby 3.2.

fluent/fluent-package-builder#429

We need to decide how should we treat gems that doesn't support Ruby 3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants