Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining issues to support Ruby 3.2 #429

Closed
3 tasks done
ashie opened this issue Feb 8, 2023 · 4 comments · Fixed by #434
Closed
3 tasks done

Remaining issues to support Ruby 3.2 #429

ashie opened this issue Feb 8, 2023 · 4 comments · Fixed by #434

Comments

@ashie
Copy link
Member

ashie commented Feb 8, 2023

Although importing Ruby 3.2 has been landed at #425, some gems are still needed to work due to missing File.exists? which has been removed as of Ruby 3.2. AFAIK following 3 gems should be fixed.

@renan-airbnb
Copy link

renan-airbnb commented Mar 17, 2023

Just wanted to chime in and say this is a blocker for packaging on Amazon Linux 2023. Unlike Amazon Linux 2022, AL2023 does not have the ruby3.1 package used to build in AL2022 😞.

@ashie
Copy link
Member Author

ashie commented Mar 30, 2023

Just wanted to chime in and say this is a blocker for packaging on Amazon Linux 2023. Unlike Amazon Linux 2022, AL2023 does not have the ruby3.1 package used to build in AL2022 disappointed.

Don't worry, it's still there and buildable: #435

ashie added a commit that referenced this issue Mar 30, 2023
Fix #429

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
@renan-airbnb
Copy link

It's actually pulling in ruby3.2 when you use ruby3.1 as a dependency:

docker run -it --platform linux/amd64 public.ecr.aws/amazonlinux/amazonlinux:2023 /bin/bash           ✘ INT 1m 1s
bash-5.2# yum install ruby3.1
Amazon Linux 2023 repository                                                                                                                          4.5 MB/s |  12 MB     00:02
Last metadata expiration check: 0:00:03 ago on Thu Mar 30 17:06:40 2023.
Dependencies resolved.
======================================================================================================================================================================================
 Package                                              Architecture                     Version                                            Repository                             Size
======================================================================================================================================================================================
Installing:
 ruby3.2                                              x86_64                           3.2.0-177.amzn2023.0.1                             amazonlinux                            45 k
Installing dependencies:
 ruby3.2-default-gems                                 noarch                           3.2.1-179.amzn2023.0.1                             amazonlinux                            36 k
 ruby3.2-libs                                         x86_64                           3.2.0-177.amzn2023.0.1                             amazonlinux                           4.0 M
 ruby3.2-rubygem-io-console                           x86_64                           0.6.0-179.amzn2023.0.1                             amazonlinux                            28 k
 ruby3.2-rubygem-json                                 x86_64                           2.6.3-179.amzn2023.0.1                             amazonlinux                            56 k
 ruby3.2-rubygem-psych                                x86_64                           5.0.1-179.amzn2023.0.1                             amazonlinux                            54 k
Installing weak dependencies:
 ruby3.2-rubygem-bigdecimal                           x86_64                           3.1.3-179.amzn2023.0.1                             amazonlinux                            71 k
 ruby3.2-rubygem-bundler                              noarch                           2.4.6-179.amzn2023.0.1                             amazonlinux                           386 k
 ruby3.2-rubygem-rdoc                                 noarch                           6.5.0-179.amzn2023.0.1                             amazonlinux                           463 k
 ruby3.2-rubygems                                     noarch                           3.4.6-179.amzn2023.0.1                             amazonlinux                           258 k

Transaction Summary
======================================================================================================================================================================================
Install  10 Packages

Total download size: 5.3 M
Installed size: 19 M
Is this ok [y/N]: N
Operation aborted.
bash-5.2# yum info ruby3.1
Last metadata expiration check: 0:00:19 ago on Thu Mar 30 17:06:40 2023.
Error: No matching Packages to list

In any case, with support for ruby3.2 done we should be ok. Thanks for looking into @ashie.

@ashie
Copy link
Member Author

ashie commented Mar 31, 2023

Oh I didn't notice it. Thanks for notifying it!
The ruby version for building td-agent isn't so tight, so it's no problem to use 3.2 too.
But it seems that we should fix the Dockerfile to avoid confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants