Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace prettier workspace property #76

Merged
merged 16 commits into from
Oct 11, 2024
Merged

chore: replace prettier workspace property #76

merged 16 commits into from
Oct 11, 2024

Conversation

benmccann
Copy link
Member

Make this a bit more generic. I don't know if it's scalable for every adder to add properties to the workspace for each module they might want to detect. This might be a better pattern for community adders to follow and doesn't lock us in to providing that property

Copy link

pkg-pr-new bot commented Oct 10, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/ast-tooling@76
pnpm add https://pkg.pr.new/sveltejs/cli/sv@76
pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/core@76

commit: 196af11

@benmccann benmccann changed the title chore: remove prettier workspace property chore: replace prettier workspace property Oct 10, 2024
manuel3108
manuel3108 previously approved these changes Oct 10, 2024
@manuel3108 manuel3108 dismissed their stale review October 10, 2024 15:33

Missed comments

@benmccann benmccann linked an issue Oct 10, 2024 that may be closed by this pull request
pnpm-lock.yaml Outdated Show resolved Hide resolved
@AdrianGonz97
Copy link
Member

AdrianGonz97 commented Oct 10, 2024

Err, one potential issue I just thought of is if the project may live within a monorepo, but it's not actively part of the monorepo. For instance, it's excluded from the pnpm-workspace.yaml file or workspaces: [] glob array.

Also how will this affect our tests? Maybe we should wrap it with a TESTING flag like we do for typescript detection @manuel3108?

@benmccann
Copy link
Member Author

Err, one potential issue I just thought of is if the project may live within a monorepo, but it's not actively part of the monorepo. For instance, it's excluded from the pnpm-workspace.yaml file or workspaces: [] glob array.

I suppose that's possible, but it doesn't seem super common. I don't think we're going to be able to implement that level of detail pre-launch. It seems like something we could come back and do it later if someone runs into it being an issue.

@benmccann benmccann merged commit 1453928 into main Oct 11, 2024
5 checks passed
@AdrianGonz97 AdrianGonz97 deleted the prettieer branch October 11, 2024 03:01
@manuel3108
Copy link
Member

Also how will this affect our tests? Maybe we should wrap it with a TESTING flag like we do for typescript detection @manuel3108?

Good point, added a not in #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine dependency-related workspace methods
3 participants