Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine dependency-related workspace methods #78

Closed
benmccann opened this issue Oct 10, 2024 · 1 comment · Fixed by #76
Closed

Combine dependency-related workspace methods #78

benmccann opened this issue Oct 10, 2024 · 1 comment · Fixed by #76

Comments

@benmccann
Copy link
Member

There's also the dependencies field and the only thing we use it for is to check if eslint is installed. Ideally I think we could combine it with isResolveable or whatever we call it (#76). They work slightly differently though. I think that isResolvable will work in a monorepo, but it only returns true/false. dependencies only looks at the package.json, but will return the version. Ideally we create a method that returns a version and works in a monorepo

I also think that dependencies is a bit unclear in that it contains dependencies and devDependencies

@AdrianGonz97
Copy link
Member

AdrianGonz97 commented Oct 10, 2024

I also think that dependencies is a bit unclear in that it contains dependencies and devDependencies

we settled on combining them into a single dependencies field as we couldn't think of any use-case where knowing if a dep was installed as a dependency or a devDependency would be particularly helpful

@benmccann benmccann linked a pull request Oct 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants