Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cypress] Ensure all statuses are available in sauceVisualResult summary #139

Merged
merged 2 commits into from
Sep 25, 2024
Merged

[Cypress] Ensure all statuses are available in sauceVisualResult summary #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9c283e
docs(changeset): Fill out statuses in sauceVisualResults for cypress
Sep 24, 2024
4427557
Fill out statuses in sauceVisualResults for cypress
Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions visual-js/.changeset/slow-seas-occur.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"@saucelabs/cypress-visual-plugin": patch
"@saucelabs/visual": patch
"@saucelabs/nightwatch-sauce-visual-service": patch
"@saucelabs/visual-playwright": patch
"@saucelabs/visual-storybook": patch
"@saucelabs/wdio-sauce-visual-service": patch
---

Fill out statuses in sauceVisualResults for cypress
Bump all dependencies to use new ignore region calculation system
9 changes: 8 additions & 1 deletion visual-js/visual-cypress/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,14 @@ Sauce Labs Visual: Unable to create new build.

const filterDiffsById = (diff: { id: string; status: DiffStatus }) =>
this.uploadedDiffIds.includes(diff.id);
const initialStatusSummary = {} as Record<DiffStatus, number>;
const initialStatusSummary = {
[DiffStatus.Queued]: 0,
[DiffStatus.Unapproved]: 0,
[DiffStatus.Approved]: 0,
[DiffStatus.Equal]: 0,
[DiffStatus.Errored]: 0,
[DiffStatus.Rejected]: 0,
} satisfies Record<DiffStatus, number>;
const statusSummary = diffsForTestResult.nodes
.filter(filterDiffsById)
.reduce((statusSummary, diff) => {
Expand Down