Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cypress] Ensure all statuses are available in sauceVisualResult summary #139

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

omacranger
Copy link
Member

Description

Our docs say you can use the sauceVisualResult summary to check the status of a result and assert that a certain status is never found. Currently, however, that object is empty so asserting unapproved = 0 would never pass.

This PR does the following:

  • This updates the check to populate all the keys of our DiffStatus into the initial value before reducing over the nodes.
  • This also bumps all other bindings by a patch to roll out the new server-side ignore region calculation.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

Copy link
Contributor

@paweltomaszewskisaucelabs paweltomaszewskisaucelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this change impacting only

@omacranger omacranger merged commit 5991881 into main Sep 25, 2024
2 checks passed
@omacranger omacranger deleted the bugfix/cypress-result-keys branch September 25, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants