-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc Fixes #2125
base: main
Are you sure you want to change the base?
Misc Fixes #2125
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the future, find a way to scan all files with parinfer. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ $(MODULES): | |
$(MAKE) -C $@ $(MAKECMDGOALS) | ||
|
||
fmt-root: | ||
cljfmt check dev resources src test deps.edn tests.edn | ||
cljfmt check dev modules profiling resources src test deps.edn tests.edn | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need the check the whole modules dir here, because that is done at module level. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And I miss the fixed profiling namespace. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
See TODO here: |
||
|
||
fmt: $(MODULES) fmt-root | ||
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TODO: review REPL aliases.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Maintain the same style in:
/dev/blaze/dev.clj
, and in/profiling/blaze/profiling.edn