Misc Fixes #2125
Draft
Misc Fixes #2125
+14
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
allentiak
commented
Oct 18, 2024
There was a problem hiding this comment.
TODO: Maintain the same style in:
/dev/blaze/dev.clj, and in/profiling/blaze/profiling.edn
allentiak
commented
Oct 18, 2024
There was a problem hiding this comment.
For the future, find a way to scan all files with parinfer.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2125 +/- ##
=======================================
Coverage 94.99% 94.99%
=======================================
Files 330 330
Lines 20158 20158
Branches 482 482
=======================================
Hits 19149 19149
Misses 527 527
Partials 482 482 |
allentiak
commented
Oct 18, 2024
There was a problem hiding this comment.
TODO: review REPL aliases.
- assess whether it is possible and desirable to add the
testpath to the global REPL, so we don't need per-module explicit REPL setup anymore.
alexanderkiel
requested changes
Oct 18, 2024
| @@ -4,7 +4,7 @@ $(MODULES): | |||
| $(MAKE) -C $@ $(MAKECMDGOALS) | |||
|
|
|||
| fmt-root: | |||
| cljfmt check dev resources src test deps.edn tests.edn | |||
| cljfmt check dev modules profiling resources src test deps.edn tests.edn | |||
There was a problem hiding this comment.
No need the check the whole modules dir here, because that is done at module level. profiling is ok.
There was a problem hiding this comment.
And I miss the fixed profiling namespace.
There was a problem hiding this comment.
And I miss the fixed profiling namespace.
See TODO here:
#2125 (comment)
allentiak
force-pushed
the
misc-fixes
branch
2 times, most recently
from
ca41c01
to
fdefc4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modulesandprofilingfoldersdocs/implementation/fhir-data-model.md