Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memset hook #866

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Memset hook #866

merged 6 commits into from
Oct 20, 2023

Conversation

mariaKt
Copy link
Contributor

@mariaKt mariaKt commented Oct 17, 2023

This PR adds a hook that implements memset for the llvm backend. We intend to use this to perform copies while avoiding the overhead of an extra buffer copy in the C semantics.

@mariaKt mariaKt marked this pull request as ready for review October 17, 2023 22:32
Copy link
Contributor

@Baltoli Baltoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very pedantic comment but otherwise this looks great - thanks @mariaKt

runtime/strings/bytes.cpp Show resolved Hide resolved
Copy link
Contributor

@Baltoli Baltoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rv-jenkins rv-jenkins merged commit 480b542 into master Oct 20, 2023
5 checks passed
@rv-jenkins rv-jenkins deleted the bytes-memset branch October 20, 2023 13:25
rv-jenkins pushed a commit to runtimeverification/k that referenced this pull request Oct 20, 2023
This PR adds support in the frontend for the `memset` hook, implemented
[here](runtimeverification/llvm-backend#866) for
the llvm backend.

---------

Co-authored-by: Bruce Collie <brucecollie82@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants