Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for memset hook. #3722

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Support for memset hook. #3722

merged 3 commits into from
Oct 20, 2023

Conversation

mariaKt
Copy link
Contributor

@mariaKt mariaKt commented Oct 17, 2023

This PR adds support in the frontend for the memset hook, implemented here for the llvm backend.

@rv-jenkins rv-jenkins changed the base branch from master to develop October 17, 2023 21:20
@mariaKt mariaKt marked this pull request as ready for review October 17, 2023 22:32
Baltoli
Baltoli suggested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@Baltoli Baltoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get an integration test for this change? It can just be a K definition that does the same things as the unit tests from the backend, but makes sure that the hook exists and is wired up to the backend correctly.

k-distribution/include/kframework/builtin/domains.md Outdated Show resolved Hide resolved
Baltoli
Baltoli approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@Baltoli Baltoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rv-jenkins rv-jenkins merged commit bdde319 into develop Oct 20, 2023
8 checks passed
@rv-jenkins rv-jenkins deleted the bytes-memset branch October 20, 2023 19:42
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baltoli Baltoli Baltoli approved these changes

@dwightguth dwightguth Awaiting requested review from dwightguth

@ehildenb ehildenb Awaiting requested review from ehildenb ehildenb is a code owner

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariaKt @Baltoli @rv-jenkins