fix bugs with serializeConfiguration and garbage collection #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in how we were serializing string buffers and strings/byte arrays of length 0. It was assuming that such strings are null terminated when they appear in a
string *in the kore heap, but this is not necessarily true. Similarly, it was assuming that a string buffer was null terminated, which is also not true.It's pretty difficult to write reliable tests for this bug since it relies on garbage collection to pollute the word that gets printed with a word that does not begin with the null byte. This is impossible in our existing test harness for serialization since we don't ever garbage collect anything in those tests. However, we know that the fix works because it fixes the regression in the Booster's integration tests that arose from introducing garbage collection calls to their API usage.