Fix a couple memory leaks #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -342,9 +347,11 @@ mkAPI dlib = flip runReaderT dlib $ do | |||
| } | |||
| len <- fromIntegral <$> peek lenPtr | |||
| cstr <- peek strPtr | |||
| BS.packCStringLen (cstr, len) | |||
| result <- BS.packCStringLen (cstr, len) | |||
| Foreign.free cstr | |||
There was a problem hiding this comment.
Thanks for the spot here. I think I assumed that packCStringLen just wraps the pointer, but upon checking it copies the memory. I wonder if it would be worth passing this pointer tot he parse function and freeing after to avoid this copy? Not sure how big the returned data can be.... perhaps something to investigate later
There was a problem hiding this comment.
It might be worth it if we see performance issues related to this in a profile, but the advantage of this approach is that the native memory that is allocated is all isolated to this particular component, and all memory that gets used moving forward is just regular haskell heap memory. So I don't think we should prematurely optimize here.
goodlyrottenapple
previously approved these changes
Aug 17, 2023
dwightguth
force-pushed
the
memory_leak
branch
from
c4adbb9
to
b35b48d
Compare
rv-jenkins
pushed a commit
that referenced
this pull request
Aug 22, 2023
This is a cherry-pick from #263 that we could merge much faster without investigating LLVM backend bindings. Co-authored-by: Dwight Guth <dwight.guth@runtimeverification.com>
goodlyrottenapple
approved these changes
Aug 24, 2023
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #264
We were never taking any rewrite steps, so the garbage collector was never getting called. We also forgot to call kllvm_init, which meant that some of the memory that ought to have been allocated on the garbage collected heap in the llvm backend was instead being allocated in the wrong place.
Finally, we forgot to call
freeon thechar*returned fromkore_simplify.