Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions as params #853

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Functions as params #853

merged 3 commits into from
Jul 24, 2023

Conversation

markwpearce
Copy link
Collaborator

  • Fixes validations when a function is used as a parameter
  • Validates non-functions passed as arguments
  • Adds TypedFunctionType class for functions with known param types & return types

TwitchBronBron
TwitchBronBron requested changes Jul 22, 2023
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a few places where you might be using TypedFunctionType when you needed to use FunctionType or isCallableType?

src/Program.ts Outdated Show resolved Hide resolved
src/Scope.ts Outdated Show resolved Hide resolved
src/bscPlugin/hover/HoverProcessor.ts Show resolved Hide resolved
src/bscPlugin/validation/ScopeValidator.ts Show resolved Hide resolved
src/util.ts Outdated Show resolved Hide resolved
@markwpearce
Copy link
Collaborator Author

Fixed the places that needed it

@markwpearce markwpearce merged commit 53c7160 into release-0.66.0 Jul 24, 2023
5 checks passed
@markwpearce markwpearce deleted the function_types_as_params branch July 24, 2023 14:18
@TwitchBronBron TwitchBronBron added this to the v1.0.0 milestone Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron Awaiting requested review from TwitchBronBron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@markwpearce @TwitchBronBron