Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix direction bug in PhysicsUpdateSystem #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix direction bug in PhysicsUpdateSystem #23

wants to merge 1 commit into from

Commits on Aug 9, 2022

  1. Fix direction bug in PhysicsUpdateSystem 

    In the prior version of `PhysicsUpdateSystem` logic, if the `PhysicsBody.body.velocity.x`
velocity is zero, the `Position.direction.x` will always be updated to point to the negative direction.

This was causing the following problematic behavior:
- an entity that "walks" rightward and is stopped by a "wall"
  will switch to facing left when it comes to a stop
- an entity that "walks" leftward and is stopped by a "wall"
  will continue facing left when it comes to a stop

After this commit, the behavior is fixed and made consistent by ensuring that
when the X velocity is zero we do not update the X direction.
    @jemc
    jemc authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    528df1f View commit details
    Browse the repository at this point in the history