docker: podman-friendly image locations #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #730 +/- ##
==========================================
- Coverage 18.90% 18.87% -0.04%
==========================================
Files 26 26
Lines 2195 2199 +4
==========================================
Hits 415 415
- Misses 1780 1784 +4
|
tiborsimko
force-pushed
the
podman-friendly
branch
2 times, most recently
from
13a0bd5
to
cea49fc
Compare
mdonadoni
approved these changes
Aug 3, 2023
tiborsimko
force-pushed
the
podman-friendly
branch
4 times, most recently
from
0203a3d
to
e9a7028
Compare
tiborsimko
commented
Aug 7, 2023
| default: | ||
| base: auto | ||
| target: auto | ||
| threshold: 2% |
There was a problem hiding this comment.
@mdonadoni Changes to code coverage settings were necessary due to codecov updates. The values above are one possibility how to make CI pass and yet encourage some code coverage. Let's discuss IRL tomorrow what targets and thresholds we would like to aim at.
tiborsimko
force-pushed
the
podman-friendly
branch
from
e9a7028
to
1d0c790
Compare
Adds desired targets and threshold values for code coverage tests in pull requests. Removes custom code coverage range to fall back to codecov defaults.
tiborsimko
force-pushed
the
podman-friendly
branch
from
1d0c790
to
9af21ae
Compare
Adds fully qualified canonical locations of container images, making the container technology setup podman-friendly. Amends cluster creation scripts to support either Docker or Podman container technologies based on `docker version` information. Closes reanahub#729.
tiborsimko
force-pushed
the
podman-friendly
branch
from
9af21ae
to
e0c0138
Compare
|
(1) The 34 PR set is finished and the tests are passing with Podman: $ reana-dev run-ci -m /var/reana:/var/reana -c r-d-r-roofit --admin-email xxx --admin-password yyy
...
$ reana-dev run-example -c DEMO --submit-only
...
$ reana-dev run-example -c DEMO --check-only
...
Test matrix:
- 9 demo example(s): reana-demo-alice-lego-train-test-run, reana-demo-alice-pt-analysis, reana-demo-atlas-recast, reana-demo-bsm-search, reana-demo-cms-dimuon-mass-spectrum, reana-demo-cms-h4l, reana-demo-helloworld, reana-demo-root6-roofit, reana-demo-worldpopulation
- 4 workflow engine(s): cwl, serial, snakemake, yadage
- 1 compute backend(s): kubernetes
Test results:
- 18 submitted: alice-lego-train-test-run-serial-kubernetes, alice-pt-analysis-serial-kubernetes, atlas-recast-yadage-kubernetes, bsm-search-yadage-kubernetes, cms-dimuon-mass-spectrum-serial-kubernetes, cms-h4l-snakemake-kubernetes, helloworld-cwl-kubernetes, helloworld-serial-kubernetes, helloworld-snakemake-kubernetes, helloworld-yadage-kubernetes, root6-roofit-cwl-kubernetes, root6-roofit-serial-kubernetes, root6-roofit-snakemake-kubernetes, root6-roofit-yadage-kubernetes, worldpopulation-cwl-kubernetes, worldpopulation-serial-kubernetes, worldpopulation-snakemake-kubernetes, worldpopulation-yadage-kubernetes
- 0 running
- 0 pending
- 0 queued
- 18 passed
- 0 failed
OKGoing to test with Docker later this evening... (2) Check out the full PR set by using: reana-dev git-fetch -c ALL
reana-dev git-checkout-pr \
-b blog.reana.io 37 \
-b docs.reana.io 175 \
-b pytest-reana 108 \
-b reana 730 \
-b reana-auth-krb5 9 \
-b reana-auth-rucio 4 \
-b reana-auth-vomsproxy 18 \
-b reana-client 661 \
-b reana-client-go 145 \
-b reana-commons 404 \
-b reana-db 197 \
-b reana-demo-alice-lego-train-test-run 22 \
-b reana-demo-alice-pt-analysis 8 \
-b reana-demo-atlas-recast 44 \
-b reana-demo-bsm-search 28 \
-b reana-demo-cdci-crab-pulsar-integral-verification 11 \
-b reana-demo-cms-dimuon-mass-spectrum 12 \
-b reana-demo-cms-h4l 23 \
-b reana-demo-cms-reco 29 \
-b reana-demo-helloworld 62 \
-b reana-demo-lhcb-d2pimumu 13 \
-b reana-demo-root6-roofit 63 \
-b reana-demo-worldpopulation 53 \
-b reana-env-aliphysics 6 \
-b reana-env-jupyter 13 \
-b reana-env-root6 17 \
-b reana-job-controller 392 \
-b reana-message-broker 52 \
-b reana-server 604 \
-b reana-ui 336 \
-b reana-workflow-controller 513 \
-b reana-workflow-engine-cwl 241 \
-b reana-workflow-engine-serial 178 \
-b reana-workflow-engine-snakemake 58 \
-b reana-workflow-engine-yadage 240 \
-b www.reana.io 77(3) Run the usual |
mdonadoni
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fully qualified canonical locations of container images, making the container technology setup podman-friendly.
Amends cluster creation scripts to support either Docker or Podman container technologies based on
docker versioninformation.Closes #729.