Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torchcodec] Revert register_fake back to imply_abstract #69

Closed
wants to merge 1 commit into from
Closed

[torchcodec] Revert register_fake back to imply_abstract #69

wants to merge 1 commit into from

Commits on Jul 9, 2024

  1. [torchcodec] Revert register_fake back to imply_abstract (#69) 

    Summary:
Pull Request resolved: #69

`register_fake` is only available after Pytorch 2.4, which will be available in late July. We don't want to break user experience if they on old pytorch versions. It is also possible when we release torchcodec, pytorch 2.4 not yet released.

Note: it's expected that reverting back will trigger a lot of logging.

Reviewed By: NicolasHug

Differential Revision: D59018191
    @kaiyuey @facebook-github-bot
    kaiyuey authored and facebook-github-bot committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5018f38 View commit details
    Browse the repository at this point in the history