[torchcodec] Revert register_fake back to imply_abstract #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59018191 |
Summary: Pull Request resolved: #69 `register_fake` is only available after Pytorch 2.4, which will be available in late July. We don't want to break user experience if they on old pytorch versions. It is also possible when we release torchcodec, pytorch 2.4 not yet released. Note: it's expected that reverting back will trigger a lot of logging. Reviewed By: NicolasHug Differential Revision: D59018191
|
This pull request was exported from Phabricator. Differential Revision: D59018191 |
|
This pull request has been merged in 007d9b4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
register_fakeis only available after Pytorch 2.4, which will be available in late July. We don't want to break user experience if they on old pytorch versions. It is also possible when we release torchcodec, pytorch 2.4 not yet released.Note: it's expected that reverting back will trigger a lot of logging.
Differential Revision: D59018191