This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pitgull bootstrap cli #264
Pitgull bootstrap cli #264
Changes from 15 commits
8967c1c
a0992d9
628ec6f
ccc3b5d
e906f5a
4be5d69
c7d209a
a250e9c
8627f8a
9ff5c41
e73fb2f
b5afe33
d1051a6
d929b29
b778495
2ac8fd9
45a7e70
6f3e26f
3f83775
a6c3ded
66c1ad4
3c2c6fe
a97d0c8
ae4c417
45f6991
2d5d4b1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this made me realize we should have a sub-package there.
org.polyvariant.bootstrap
orio.pg.bootstrap
for consistency with the rest :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about renaming this one to
org.polyvariant.pitgull.bootstrap
and creating ticket to repackageio.pg
in main application toorg.polyvariant.pitgull.app
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convince me why that's better and we can do it :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better because:
pg.io
, and it's registered till 2027I'd say let's leave the package name unchanged for now, and sort this out in separate PR.