-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
b74aab9
to
4be5d69
Compare
In @kubukoz any ideas? should we keep |
Apparently there's a fix for that in the library. I didn't notice it at the first glance: sbt/sbt-github-actions#60 (comment) |
9ed6734
to
b5afe33
Compare
c4e8303
to
d929b29
Compare
build.sbt
Outdated
), | ||
testFrameworks += new TestFramework("weaver.framework.TestFramework"), | ||
publish / skip := true, | ||
Compile / mainClass := Some("org.polyvariant.Main"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this made me realize we should have a sub-package there. org.polyvariant.bootstrap
or io.pg.bootstrap
for consistency with the rest :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about renaming this one to org.polyvariant.pitgull.bootstrap
and creating ticket to repackage io.pg
in main application to org.polyvariant.pitgull.app
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convince me why that's better and we can do it :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better because:
- We can avoid confusion - package name matches the organization name
- Someone else owns
pg.io
, and it's registered till 2027
Domain Name: PG.IO
Registry Domain ID: D503300000040413631-LRMS
...
Creation Date: 2003-09-22T14:07:39Z
Registry Expiry Date: 2027-04-30T12:00:00Z
I'd say let's leave the package name unchanged for now, and sort this out in separate PR.
Co-authored-by: Jakub Kozłowski <kubukoz@gmail.com>
No description provided.