Remove 'Discussion Item' from SearchSchema (helps also to turn pa.discussion into a core addon) #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensens
added
03 type: feature (plip)
|
@jensens thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
jensens
force-pushed
the
pa-discussion-core-addon
branch
from
4e9d66b
to
df68d4b
Compare
remove impossible values, since there never is the construction allowed of these two see vocabulary plone.app.vocabularies.PortalTypes and https://github.com/zopefoundation/Products.CMFCore/blob/8d765b8ce7ec4e053e58f5c8dc45d08db01ce3e0/src/Products/CMFCore/TypesTool.py#L768
jensens
force-pushed
the
pa-discussion-core-addon
branch
from
df68d4b
to
f3f45a9
Compare
|
@jenkins-plone-org please run jobs |
jensens
changed the title
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With plone.app.discussion
Discussion Itemis not available by default.But: "TempFolder" and "Plone Site" are at no time in the constraint vocabulary used. So I removed them as well.
see plone/plone.app.discussion#211
This one can be merged alone and is valid for 6.0 too.