Merge pull request #65 from plone/pa-discussion-core-addon

Remove 'Discussion Item' from SearchSchema (helps also to turn pa.discussion into a core addon)
plone · May 30, 2024 · 53723bb · 53723bb
2 parents a3ff26f + a9ed087
commit 53723bb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/news/65.bugfix b/news/65.bugfix
@@ -0,0 +1,4 @@
+Remove ISearchSchemas types_not_searched "Discussion Item" value to make plone.app.discussion a core addon.
+It is actually not needed anyway, also not part of the underlying vocabulary and would be lost on first save in control-panel.
+See https://github.com/zopefoundation/Products.CMFCore/blob/8d765b8ce7ec4e053e58f5c8dc45d08db01ce3e0/src/Products/CMFCore/TypesTool.py#L768
+[@jensens]
diff --git a/src/plone/base/interfaces/controlpanel.py b/src/plone/base/interfaces/controlpanel.py
@@ -1015,8 +1015,10 @@ class ISearchSchema(Interface):
  "off here or by the relevant installer."
  ),
  required=False,
+ # XXX: Actually, the Plone Site and TempFolder are not part of the vocabulary
+ # and would be removed from the list of types not searched on first save in ControlPanel!
+ # Both are used in many tests and kept for now.
  default=(
- "Discussion Item",
  "Plone Site",
  "TempFolder",
  ),