-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installaton methods in README.md #643
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -222,6 +222,14 @@ command not found: node | |
|
||
# Getting Started | ||
|
||
The easiest way to install tea is with our installer: | ||
|
||
```sh | ||
sh <(curl https://tea.xyz) | ||
``` | ||
|
||
You could also use Homebrew: | ||
|
||
```sh | ||
brew install teaxyz/pkgs/tea-cli | ||
``` | ||
|
@@ -230,8 +238,8 @@ If you prefer, tea is a standalone, cross-platform binary that you can install | |
anywhere you want ([releases]). Here’s a handy one-liner: | ||
|
||
```sh | ||
sudo install -m 755 \ | ||
<(curl --compressed -LSsf https://tea.xyz/$(uname)/$(uname -m)) \ | ||
sudo install -m 755 \\ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. whoops and thanks There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems actually these aren't required. |
||
<(curl --compressed -LSsf https://tea.xyz/$(uname)/$(uname -m)) \\ | ||
/usr/local/bin/tea | ||
``` | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually deliberately removed this recently to encourage people to install via brew as our suggested workflow.
magic can then be added manually, and I intend to improve that.
there's too much worry regarding
curl | sh
installers nowadays and it hinders our adoption.So yeah, please remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, would you like to leave only brew installation instruction in the README? I think it'd limit adoption further as well, especially for Linux folks, I guess brew is not that popular on that platform as it is on mac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instructions also provide a one-liner for installation for people without brew.
so far we've experienced severe reluctance to use our curl installer. So severe I'm just removing it. Use brew or download the standalone
tea
binary.It's weird since this method is used for brew installation; and I wrote the brew curl installer. But people are what they are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit: and you say the one-liner doesn't work for linux intel so we should fix that. I added a comment below about that.