Update installaton methods in README.md #643
Conversation
The previous command did not work on a typical x86 Linux system. The link generated by the script - https://tea.xyz/Linux/x86_64 - was invalid. The updated command is taken directly from https://docs.tea.xyz/getting-started/install-tea
PR Summary
|
|
Reading the docs, I realized that you actually want to support both the script I removed in the PR, and the one I added. Then, the proper modification would be to:
|
marcinjahn
changed the title
| The easiest way to install tea is with our installer: | ||
|
|
||
| ```sh | ||
| sh <(curl https://tea.xyz) |
There was a problem hiding this comment.
I actually deliberately removed this recently to encourage people to install via brew as our suggested workflow.
magic can then be added manually, and I intend to improve that.
there's too much worry regarding curl | sh installers nowadays and it hinders our adoption.
So yeah, please remove.
There was a problem hiding this comment.
So, would you like to leave only brew installation instruction in the README? I think it'd limit adoption further as well, especially for Linux folks, I guess brew is not that popular on that platform as it is on mac.
There was a problem hiding this comment.
The instructions also provide a one-liner for installation for people without brew.
so far we've experienced severe reluctance to use our curl installer. So severe I'm just removing it. Use brew or download the standalone tea binary.
It's weird since this method is used for brew installation; and I wrote the brew curl installer. But people are what they are.
There was a problem hiding this comment.
edit: and you say the one-liner doesn't work for linux intel so we should fix that. I added a comment below about that.
| @@ -230,8 +238,8 @@ If you prefer, tea is a standalone, cross-platform binary that you can install | |||
| anywhere you want ([releases]). Here’s a handy one-liner: | |||
|
|
|||
| ```sh | |||
| sudo install -m 755 \ | |||
| <(curl --compressed -LSsf https://tea.xyz/$(uname)/$(uname -m)) \ | |||
| sudo install -m 755 \\ | |||
There was a problem hiding this comment.
seems actually these aren't required.
@jhheider what we got and what do we need to fix this? |
$ curl -OL https://tea.xyz/Linux/x86_64
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 103 100 103 0 0 239 0 --:--:-- --:--:-- --:--:-- 241
100 98.1M 100 98.1M 0 0 25.2M 0 0:00:03 0:00:03 --:--:-- 32.4M
$ file x86_64
x86_64: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, with debug_info, not strippedThat looks right to me. @marcinjahn did you use |
It actually works today, unlike when I originally had tried it. Anyway, it seems that the proposed changes are not actually needed, I'll close the PR. |
The previous command did not work on a typical x86 Linux system. The link generated by the script - https://tea.xyz/Linux/x86_64 - was invalid. The updated command is taken directly from https://docs.tea.xyz/getting-started/install-tea