Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bin/jpackage for now to fix openjdk@11 #5505

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Mar 9, 2024

I think this is the best compromise for the time being. bin/jpackage is only available for jdk17+.

          Looks like it failed the audit due to a missing binary:

https://github.com/pkgxdev/pantry/actions/runs/8210262716/job/22457399093

Originally posted by @jhheider in #5472 (comment)

Refs pkgxdev/libpkgx#68

@felipecrs
Copy link
Contributor Author

One sec, I think there are more differences. I'm double checking.

@felipecrs felipecrs marked this pull request as draft March 9, 2024 18:15
@felipecrs felipecrs changed the title rm jpackage as bin for now Remove bin/jpackage for now to fix openjdk@11 Mar 9, 2024
@felipecrs
Copy link
Contributor Author

Done documenting all bins diffs.

@felipecrs felipecrs marked this pull request as ready for review March 9, 2024 18:23
@jhheider jhheider merged commit 405e904 into pkgxdev:main Mar 9, 2024
5 checks passed
@felipecrs felipecrs deleted the rm-jpackage branch March 9, 2024 18:44
@jhheider
Copy link
Contributor

it looks like clang 15 is still erroring for linux:

https://github.com/pkgxdev/pantry/actions/runs/8216510165/job/22471169048

@felipecrs
Copy link
Contributor Author

I will check this better tomorrow. The only explanation is that perhaps my bk build command was using some cached llvm.org.

@jhheider
Copy link
Contributor

possibly cached build products. bk build --clean openjdk.org^11 is slower (since it cleans everything), but won't have old intermediate products.

@felipecrs
Copy link
Contributor Author

I was actually using --clean every time. However, my suspicious is that, since I first tried with llvm<14, all following builds would be reusing it since 13 satisfies llvm<16 for example.

@jhheider
Copy link
Contributor

ah, very possible. ^{{major}} will help with that when testing.

@felipecrs felipecrs mentioned this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants