Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openjdk.org@11) #5530

Merged
merged 1 commit into from
Mar 10, 2024
Merged

fix(openjdk.org@11) #5530

merged 1 commit into from
Mar 10, 2024

Conversation

felipecrs
Copy link
Contributor

Based on @jhheider's idea: #5472 (comment)

I think it's ok, considering someday pkgxdev/brewkit#319 should land.

@felipecrs felipecrs changed the title fix(openjdk.org@11 fix(openjdk.org@11) Mar 10, 2024
@felipecrs felipecrs marked this pull request as ready for review March 10, 2024 20:01
@felipecrs
Copy link
Contributor Author

I was able to reproduce the error, and to confirm that this fixes the issue (at least on my machine lol).

@jhheider jhheider merged commit 5ad19d4 into pkgxdev:main Mar 10, 2024
5 checks passed
@felipecrs felipecrs deleted the fix-openjdk.org@11 branch March 11, 2024 20:01
@felipecrs
Copy link
Contributor Author

@jhheider I see that v11 is listed on the website now (https://pkgx.dev/pkgs/openjdk.org/) but it seems not available through CLI.

Did the build fail by any chance?

@jhheider
Copy link
Contributor

darwin failed because of 7901ee0.

should be almost done: https://github.com/pkgxdev/pantry/actions/runs/8238670098

@jhheider
Copy link
Contributor

thanks for all your hard work here @felipecrs. there's a lot we can do, but have domain-specific users helping makes it all much easier.

if you do decide to try and build openjdk.org/v8 with only x86-64 support, we should remember to start with a nice, old llvm. I think we have back to v10, and could probably build older ones, if we got really into it.

@felipecrs
Copy link
Contributor Author

darwin failed because of 7901ee0.

should be almost done: https://github.com/pkgxdev/pantry/actions/runs/8238670098

It's available now. Super thanks for everything!

thanks for all your hard work here @felipecrs. there's a lot we can do, but have domain-specific users helping makes it all much easier.

Don't mention it, and yeah, for sure, there are so many things to build.

if you do decide to try and build openjdk.org/v8 with only x86-64 support, we should remember to start with a nice, old llvm. I think we have back to v10, and could probably build older ones, if we got really into it.

Yes, sure, point taken. I just don't promise anything soon because this week will be a busy one on my end.

@jhheider
Copy link
Contributor

No promises needed. We appreciate all the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants