chore: bump alloy-eip7702 #11986
Merged
chore: bump alloy-eip7702 #11986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
joshieDo,
Rjected and
gakonst
as code owners
|
book workspace is failing to compile (because main is broken after alloy bump) it should get fine once this is merged though it's blocking some of the tests |
shekhirin
approved these changes
Oct 23, 2024
onbjerg
approved these changes
Oct 23, 2024
onbjerg
approved these changes
Oct 23, 2024
onbjerg
added
A-dependencies
mattsse
approved these changes
Oct 23, 2024
| buf.put_u8(v.y_parity_byte()); | ||
| buf.put_slice(r.as_le_slice()); | ||
| buf.put_slice(s.as_le_slice()); | ||
| buf.put_u8(self.y_parity()); |
There was a problem hiding this comment.
this looks correct now because this always writes the u8 value as is
mattsse
reviewed
Oct 23, 2024
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encodable/Decodableimpls for encoding/decoding sidecars. Format for those was changed in fix: correct implementations of Encodable and Decodable for sidecars alloy-rs/alloy#1528 so I've replaced allencodewithrlp_encode_fieldsanddecodewithrlp_decode_fields.