ci: pass --locked and use path deps in book
#11991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
force-pushed
the
onbjerg/lock-deps
branch
2 times, most recently
from
ae0343f
to
ec81924
Compare
|
This currently does not fix the merge queue issues because of Lines 54 to 55 in 6e51762 |
mattsse
approved these changes
Oct 23, 2024
|
the arg is also provided multiple times |
onbjerg
force-pushed
the
onbjerg/lock-deps
branch
from
ec81924
to
f9d2cbb
Compare
onbjerg
force-pushed
the
onbjerg/lock-deps
branch
from
f9d2cbb
to
5188ac7
Compare
onbjerg
changed the title
--locked--locked and use path deps in book
onbjerg
force-pushed
the
onbjerg/lock-deps
branch
from
5188ac7
to
7fa758a
Compare
shekhirin
approved these changes
Oct 23, 2024
onbjerg
force-pushed
the
onbjerg/lock-deps
branch
from
7fa758a
to
a10151c
Compare
onbjerg
force-pushed
the
onbjerg/lock-deps
branch
from
a10151c
to
45e6fe2
Compare
|
This actually won't unblock CI as is, but will unblock CI for #11986. We should probably just roll the path patch into that PR 🙃 Alternatively we can force merge this and rebase that PR on top, but it's blocked by revm release |
|
Rolled into the alloy bump pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were updating the lockfile in some CI workflows which breaks if e.g. Alloy has breaking changes.
To fix the book workflow, we use path dependencies