Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add genai system-specific conventions for Azure AI Inference #1393

Merged
merged 8 commits into from
Oct 10, 2024
Merged

Add genai system-specific conventions for Azure AI Inference #1393

merged 8 commits into from
Oct 10, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Sep 5, 2024 •
edited
Loading

Adds

  • az.ai.inference system name.
  • md file describing how generic conventions apply to Azure AI Inference

It's being implemented in Azure/azure-sdk-for-js#30800 and Azure/azure-sdk-for-python#36890, other languages to follow

Merge requirement checklist

@lmolkova lmolkova requested review from a team September 5, 2024 22:06
lmolkova
lmolkova commented Sep 5, 2024
View reviewed changes
model/trace/gen-ai.yaml Outdated Show resolved Hide resolved
@lmolkova lmolkova requested a review from a team September 5, 2024 22:15
lmolkova
lmolkova commented Sep 5, 2024
View reviewed changes
model/registry/gen-ai.yaml Outdated Show resolved Hide resolved
This was referenced Sep 5, 2024
Merged
Open
Closed
drewby
drewby reviewed Sep 6, 2024
View reviewed changes
model/trace/gen-ai.yaml Outdated Show resolved Hide resolved
docs/gen-ai/azure-ai-inference.md Show resolved Hide resolved
@lmolkova lmolkova mentioned this pull request Sep 11, 2024
Merged
truptiparkar7
truptiparkar7 approved these changes Sep 26, 2024
View reviewed changes
Copy link

@truptiparkar7 truptiparkar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks great, is aligned with our product strategy and is very helpful for us. Thanks!

codefromthecrypt
codefromthecrypt reviewed Oct 3, 2024
View reviewed changes
Copy link

@codefromthecrypt codefromthecrypt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used azure much, but is deployment a primary attribute?

(online answer: deployment is the same as the model name)

docs/gen-ai/gen-ai-spans.md Show resolved Hide resolved
codefromthecrypt
codefromthecrypt approved these changes Oct 3, 2024
View reviewed changes
Copy link

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from openai standpoint sound like the model is optional, and this is a good example of that. better to clarify indeed.

@lmolkova lmolkova requested review from a team as code owners October 4, 2024 00:31
@lmolkova lmolkova force-pushed the azure-ai-inference-semconv branch 2 times, most recently from 7d44f4c to fbcead0 Compare October 4, 2024 00:51
@lmolkova lmolkova merged commit 7abcbcb into open-telemetry:main Oct 10, 2024
13 of 14 checks passed
ChrsMark pushed a commit to ChrsMark/semantic-conventions that referenced this pull request Oct 18, 2024
@lmolkova @joaopgrassi @ChrsMark
Add genai system-specific conventions for Azure AI Inference (open-te…
520a7ab 
…lemetry#1393)

Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

@drewby drewby drewby approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@lzchen lzchen lzchen approved these changes

@TaoChenOSU TaoChenOSU TaoChenOSU approved these changes

@truptiparkar7 truptiparkar7 truptiparkar7 approved these changes

Assignees
No one assigned
Labels
area:gen-ai
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lmolkova @codefromthecrypt @drewby @joaopgrassi @lzchen @TaoChenOSU @truptiparkar7 @arminru