Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding inference trace injection #36890

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

M-Hietala
Copy link
Contributor

@M-Hietala M-Hietala commented Aug 14, 2024

Description

Adding a library that injects traces to azure-ai-inferencing.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@dargilco
Copy link
Member

Is there a need to log some HTTP request and response headers? I see you only log request and response body. Also, do we log full connection url?

@M-Hietala
Copy link
Contributor Author

Is there a need to log some HTTP request and response headers? I see you only log request and response body. Also, do we log full connection url?

These are not logged as part of the GenAI semantic conventions that are added as part of this change. Connection URI and other information that looks to be http header related seem to get traced from elsewhere.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 16, 2024

API change check

API changes are not detected in this pull request.

lmolkova
lmolkova previously approved these changes Aug 23, 2024
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

Would it be possible to try it out and attach some screenshots?

[update] nevermind, found your PR here https://github.com/Azure/azureml_run_specification/pull/1182

@lmolkova
Copy link
Member

would it be possible to add some tests (at least happy cases for chat with and without streaming, 1-2 failure cases)? They should probably live in the Azure AI inference itself

Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[deleted]

@lmolkova lmolkova dismissed their stale review August 23, 2024 04:42

approved by mistake

@M-Hietala M-Hietala marked this pull request as ready for review September 11, 2024 18:37
@scbedd
Copy link
Member

scbedd commented Oct 3, 2024

/check-enforcer override

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants