Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow @transform directive to be applied to properties. #617

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Allow @transform directive to be applied to properties. #617

wants to merge 31 commits into from

Commits on Jun 15, 2024

  1. Allow query outputs to refer to a FieldRef. (#615)

    @obi1kenobi
    obi1kenobi committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    0f83d67 View commit details
    Browse the repository at this point in the history

  2. Accept FieldRef for fold-specific field outputs in IR. (#616) 

    This lays the groundwork for allowing us to transform those values before outputting them.
    @obi1kenobi
    obi1kenobi committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    c5e1bdf View commit details
    Browse the repository at this point in the history

  3. Allow FieldRef in fold post-filtering operations. (#618) 

    This lays the groundwork for `@fold @Transform(op: "count")` followed by more `@transform` operations before a subsequent `@filter`.
    @obi1kenobi
    obi1kenobi committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    e9be0ea View commit details
    Browse the repository at this point in the history

  4. Refactor IR to allow transformed values on the LHS of filter operatio… 

    …ns. (#622)
    @obi1kenobi
    obi1kenobi committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    0e749c8 View commit details
    Browse the repository at this point in the history

  5. Initial "transform on properties" data structures and updates to erro… 

    …r infra. (#623)

* Initial draft of the data structures for transforming values.

* Update error message generation and tests.
    @obi1kenobi
    obi1kenobi committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    0b5ea39 View commit details
    Browse the repository at this point in the history

  6. Add TransformedField variant to FieldRef used for tags. (#625)

    @obi1kenobi
    obi1kenobi committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    977d1a7 View commit details
    Browse the repository at this point in the history

  7. Implement execution for @transform applied to filters' left-hand op… 

    …erand. (#626)
    @obi1kenobi
    obi1kenobi committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    387c1ff View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. Deduplicate transform groups in parser and assign Tids to each.

    @obi1kenobi
    obi1kenobi committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    1bb0dea View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Partially implement @transform on properties in frontend. 

    Only works for zero-arg transform operators, only on properties, and not tested currently. Required some noticeable refactors, and I needed an intermediate checkpoint.
    @obi1kenobi
    obi1kenobi committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    9bae1ee View commit details
    Browse the repository at this point in the history

  2. Implemented minimal portion of transform execution logic. 

    First passing end-to-end test featuring `@transform` on a property!
    @obi1kenobi
    obi1kenobi committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    0b748c2 View commit details
    Browse the repository at this point in the history

  3. Implement frontend for handling @filter on transformed properties.

    @obi1kenobi
    obi1kenobi committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    9ffbf82 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Minor cleanup refactoring.

    @obi1kenobi
    obi1kenobi committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    da48215 View commit details
    Browse the repository at this point in the history

  2. Produce proper error if count transform is used on a property-like … 

    …value.
    @obi1kenobi
    obi1kenobi committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    20cc45d View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Catch more instances of invalid @transform use and offer useful adv… 

    …ice.
    @obi1kenobi
    obi1kenobi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    54bbfca View commit details
    Browse the repository at this point in the history

  2. Implement filters, tags, and outputs for transformed fold-count values.

    @obi1kenobi
    obi1kenobi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    1a57d68 View commit details
    Browse the repository at this point in the history

  3. Handle repeated @transform(op: "count") directives where only first… 

    … is valid.
    @obi1kenobi
    obi1kenobi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    05a8caa View commit details
    Browse the repository at this point in the history

  4. Handle duplicate-output-name errors with transformed fields.

    @obi1kenobi
    obi1kenobi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    5c1226d View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Implement using transformed values in a tag.

    @obi1kenobi
    obi1kenobi committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    639131d View commit details
    Browse the repository at this point in the history

  2. Finalize implementation of outputing transformed values.

    @obi1kenobi
    obi1kenobi committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    ad7b6c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Return appropriate parser/frontend errors for invalid transforms.

    @obi1kenobi
    obi1kenobi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b3aa219 View commit details
    Browse the repository at this point in the history

  2. Report variable type conflicts in both filters and transforms.

    @obi1kenobi
    obi1kenobi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d79f172 View commit details
    Browse the repository at this point in the history

  3. Update downstream project's schemas to include new feature.

    @obi1kenobi
    obi1kenobi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    99d8189 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Fix output type inference when using tags from optional scopes.

    @obi1kenobi
    obi1kenobi committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5a31e02 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Fix variables detection in transformed properties with transformed tag.

    @obi1kenobi
    obi1kenobi committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    fd5a19c View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Handle lookups of transformed values while resolving transformed tag.

    @obi1kenobi
    obi1kenobi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1b2cde2 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. Ensure unused transform arguments are cleaned up from the stack.

    @obi1kenobi
    obi1kenobi committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    01f6a49 View commit details
    Browse the repository at this point in the history

  2. Add test case for @transform with a tag that is itself transformed.

    @obi1kenobi
    obi1kenobi committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    2685817 View commit details
    Browse the repository at this point in the history

  3. Add test coverage for cyclic uses of transform + tags.

    @obi1kenobi
    obi1kenobi committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    bf0bdcc View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. Implement sqrt transform.

    @obi1kenobi
    obi1kenobi committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    009363e View commit details
    Browse the repository at this point in the history

  2. Improve transform argument type inference test coverage.

    @obi1kenobi
    obi1kenobi committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    bed2ac5 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Merge branch 'main' into transform_on_properties

    @obi1kenobi
    obi1kenobi committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    eb72c70 View commit details
    Browse the repository at this point in the history