Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow @transform directive to be applied to properties. #617

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Allow @transform directive to be applied to properties. #617

wants to merge 31 commits into from

Conversation

obi1kenobi
Copy link
Owner

No description provided.

@obi1kenobi obi1kenobi force-pushed the transform_on_properties branch 2 times, most recently from 56521dc to ffcd417 Compare June 15, 2024 17:53
@obi1kenobi
Allow query outputs to refer to a FieldRef. (#615)
0f83d67
@obi1kenobi
Accept FieldRef for fold-specific field outputs in IR. (#616)
c5e1bdf 
This lays the groundwork for allowing us to transform those values before outputting them.
@obi1kenobi
Allow FieldRef in fold post-filtering operations. (#618)
e9be0ea 
This lays the groundwork for `@fold @Transform(op: "count")` followed by more `@transform` operations before a subsequent `@filter`.
@obi1kenobi
Refactor IR to allow transformed values on the LHS of filter operatio…
0e749c8 
…ns. (#622)
@obi1kenobi
Initial "transform on properties" data structures and updates to erro…
0b5ea39 
…r infra. (#623)

* Initial draft of the data structures for transforming values.

* Update error message generation and tests.
@obi1kenobi
Add TransformedField variant to FieldRef used for tags. (#625)
977d1a7
@obi1kenobi
Implement execution for @transform applied to filters' left-hand op…
387c1ff 
…erand. (#626)
@obi1kenobi
Deduplicate transform groups in parser and assign Tids to each.
1bb0dea
@obi1kenobi
Partially implement @transform on properties in frontend.
9bae1ee 
Only works for zero-arg transform operators, only on properties, and not tested currently. Required some noticeable refactors, and I needed an intermediate checkpoint.
@obi1kenobi
Implemented minimal portion of transform execution logic.
0b748c2 
First passing end-to-end test featuring `@transform` on a property!
@obi1kenobi
Implement frontend for handling @filter on transformed properties.
9ffbf82
@obi1kenobi
Minor cleanup refactoring.
da48215
@obi1kenobi
Produce proper error if count transform is used on a property-like …
20cc45d 
…value.
@obi1kenobi
Catch more instances of invalid @transform use and offer useful adv…
54bbfca 
…ice.
@obi1kenobi
Implement filters, tags, and outputs for transformed fold-count values.
1a57d68
@obi1kenobi
Handle repeated @transform(op: "count") directives where only first…
05a8caa 
… is valid.
@obi1kenobi
Handle duplicate-output-name errors with transformed fields.
5c1226d
@obi1kenobi
Implement using transformed values in a tag.
639131d
@obi1kenobi
Finalize implementation of outputing transformed values.
ad7b6c3
@obi1kenobi
Return appropriate parser/frontend errors for invalid transforms.
b3aa219
@obi1kenobi
Report variable type conflicts in both filters and transforms.
d79f172
@obi1kenobi
Update downstream project's schemas to include new feature.
99d8189
@obi1kenobi
Fix output type inference when using tags from optional scopes.
5a31e02
@obi1kenobi
Fix variables detection in transformed properties with transformed tag.
fd5a19c
@obi1kenobi
Handle lookups of transformed values while resolving transformed tag.
1b2cde2
@obi1kenobi
Ensure unused transform arguments are cleaned up from the stack.
01f6a49
@obi1kenobi
Add test case for @transform with a tag that is itself transformed.
2685817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@obi1kenobi