Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display notification settings tooltip as hint #1580

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

rszwajko
Copy link
Member

@rszwajko rszwajko commented Mar 30, 2022

Fixes: #1391

Before

image

After

image

After (PF4 migration complete)

image

@rszwajko rszwajko requested review from sjd78 and sgratch March 30, 2022 11:56
@rszwajko rszwajko linked an issue Mar 30, 2022 that may be closed by this pull request
@ovirt-infra
Copy link

All tests passed

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjd78 sjd78 merged commit 54c3757 into oVirt:master Apr 5, 2022
@sgratch sgratch added the Status: ON_QA status ON_QA (currently being tested) label Apr 19, 2022
@ovirt-infra
Copy link

Some tests failed

@isaranova
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: ON_QA status ON_QA (currently being tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user settings - notification settings are not persisted
5 participants