Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user settings - notification settings are not persisted #1391

Closed
sgratch opened this issue Mar 24, 2021 · 4 comments · Fixed by #1580
Closed

user settings - notification settings are not persisted #1391

sgratch opened this issue Mar 24, 2021 · 4 comments · Fixed by #1580
Assignees

Comments

@sgratch
Copy link
Member

sgratch commented Mar 24, 2021

Notification settings are not persisted. this is not saved on engine db or at all (neither on local storage). For 5 mins disabling it's OK but for an hour and more - it's not. This is user settings so it should be persistent for the user.
For more details, check #1088 (comment) (issue 11)

@sgratch
Copy link
Member Author

sgratch commented Oct 21, 2021

I don't think we'll have the capacity of supporting this for the VM portal and it doesn't seem that important to handle.
This local persistence is working for webadmin as well and no comlains till now.

But one thing that worth handling here is to let the user realize more clearly that the notifications settings are not backend persisted (while all other account settings are).

Currently this info is detailed within the tooltip info text:
"Notification settings applied here affect all notifications (including all VMs and Pools notifications) and are not persisted (a page reload will clear them)"

But it worth adding this information as an alert info field displayed within the dialog, the same as we implemented for the "Create Snapshot" dialog "All attached disks will be included in the snapshot. Content of memory can be included only if VM is running" text:
image

@rszwajko rszwajko linked a pull request Mar 30, 2022 that will close this issue
@rszwajko
Copy link
Member

@sgratch

But it worth adding this information as an alert info field displayed within the dialog,

PatternFly 4 recommends hint component in similar scenario.
See #1580 for screenshots.

@sgratch
Copy link
Member Author

sgratch commented Apr 19, 2022

@sgratch

But it worth adding this information as an alert info field displayed within the dialog,

PatternFly 4 recommends hint component in similar scenario. See #1580 for screenshots.

The hint component is not used on other web-ui dialogs where the alert - info component is used (e.g. snapshots creation as mentioned above and "pending configurations" info as mentioned below), so this adds inconsistency to the "pre PF4 massive upgrade" ui.

image

@rszwajko worth fixing now or is it part of PF4 upgrade pr?

@rszwajko
Copy link
Member

The hint component is not used on other web-ui dialogs where the alert - info component is used (e.g. snapshots creation as mentioned above and "pending configurations" info as mentioned below), so this adds inconsistency to the "pre PF4 massive upgrade" ui.

The hint component will be used instead of info alert after migration to PF4 check screenshots in #1540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants