Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update omni lock deployment and signing message hash #430

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Update omni lock deployment and signing message hash #430

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af1b85d
Update omni-lock testnet deployment
XuJiandong Jan 17, 2024
2a1a409
Update testnet info
XuJiandong Jan 20, 2024
3078e85
Mainnent info
XuJiandong Jan 22, 2024
e82ff5f
Update signing message hash conversion
XuJiandong Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 38 additions & 7 deletions rfcs/0042-omnilock/0042-omnilock.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,39 @@ Depending on the value of the flag, the auth content has the following interpret
signature verification, the same as the [SECP256K1/blake160
lock](https://github.com/nervosnetwork/rfcs/blob/780b2f98068ed2337f3a97b02ec6b5336b6fb143/rfcs/0024-ckb-genesis-script-list/0024-ckb-genesis-script-list.md#secp256k1blake160).

* 0x01~0x05: It follows the same unlocking methods used by
[PW-lock](https://github.com/lay2dev/pw-lock/blob/c2b1456bcca06c892e1bb8ec8ac0a64d4fb2b83d/c/pw_lock.h#L190-L223) with different [hash calculation](https://github.com/lay2dev/pw-lock#hash-calculation) on message. PW-lock uses keccak256 instead of blake2b which is used in omnilock.
* 0x01: It follows the unlocking method used by Ethereum. The signing message
hash(sighash_all, see [reference implementation](https://github.com/nervosnetwork/ckb-system-scripts/blob/a7b7c75662ed950c9bd024e15f83ce702a54996e/c/secp256k1_blake160_sighash_all.c#L219))
is converted as following:
```
"0x" + hex(signing message hash)
```
The hex operator is to convert binary into hex string.

* 0x03: It follows the unlocking method used by Tron. The signing message hash
is converted as following:
```
"0x" + hex(signing message hash)
```

* 0x04: It follows the unlocking method used by Bitcoin. The signing message
hash is required to be converted as following:
```
"CKB (Bitcoin Layer) transaction: 0x" + hex(signing message hash)
```
In this way, it can show message on wallets(e.g. UniSat, OKX) nicely.

* 0x05: It follows the unlocking method used by dogecoin. The signing message
hash is converted as following:
```
"0x" + hex(signing message hash)
```

* 0x12: It follows the unlocking method same to 0x02 with the signing message hash
to be converted as following:
```
"CKB transaction: 0x" + hex(signing message hash)
```
In this way, it can show message on wallets(e.g. MetaMask) nicely.


* 0x06: It follows the same unlocking method used by [CKB
Expand Down Expand Up @@ -553,7 +584,7 @@ An [implementation](https://github.com/nervosnetwork/ckb-production-scripts/blob
| ----------- | -------------------------------------------------------------------- |
| `code_hash` | 0x9b819793a64463aed77c615d6cb226eea5487ccfc0783043a587254cda2b6f26 |
| `hash_type` | `type` |
| `tx_hash` | 0xdfdb40f5d229536915f2d5403c66047e162e25dedd70a79ef5164356e1facdc8 |
| `tx_hash` | 0xc76edf469816aa22f416503c38d0b533d2a018e253e379f134c3985b3472c842 |
| `index` | `0x0` |
| `dep_type` | `code` |

Expand All @@ -563,17 +594,17 @@ An [implementation](https://github.com/nervosnetwork/ckb-production-scripts/blob
| ----------- | -------------------------------------------------------------------- |
| `code_hash` | 0xf329effd1c475a2978453c8600e1eaf0bc2087ee093c3ee64cc96ec6847752cb |
| `hash_type` | `type` |
| `tx_hash` | 0x27b62d8be8ed80b9f56ee0fe41355becdb6f6a40aeba82d3900434f43b1c8b60 |
| `tx_hash` | 0x3d4296df1bd2cc2bd3f483f61ab7ebeac462a2f336f2b944168fe6ba5d81c014 |
| `index` | `0x0` |
| `dep_type` | `code` |


Reproducible build is supported to verify the deploy script. To build the deployed the script above, one can use the following steps:

```bash
$ git clone https://github.com/nervosnetwork/ckb-production-scripts
$ cd ckb-production-scripts
$ git checkout 716433e2eb6fb862acbe8d858ab7f294d894faf5
$ git clone https://github.com/cryptape/omnilock.git
$ cd omnilock
$ git checkout cd764d
$ git submodule update --init --recursive
$ make all-via-docker
```
Expand Down