Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update omni lock deployment and signing message hash #430

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

XuJiandong
Copy link
Contributor

@XuJiandong XuJiandong commented Jan 22, 2024

PR: cryptape/omnilock#2
Also update the description of message signing hash.

@XuJiandong XuJiandong requested a review from a team as a code owner January 22, 2024 06:42
Copy link
Contributor

@Flouse Flouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion

omni_lock is deployed using Type ID which means it is upgradable.

Do you think it would be better to guide the developers to query the latest out_point:{ tx_hash, index} of the omnilock code using the get_cells RPC in this RFC? So that the dApps using omnilock don't need to update the latest out_point.tx_hash in their code when omnilock is upgraded.

Examples

Get the latest omnilock code cell on CKB mainnet

curl --location --request POST 'https://mainnet.ckb.dev/' \
  --header 'Content-Type: application/json' \
  --data-raw '{
    "id": 2,
    "jsonrpc": "2.0",
    "method": "get_cells",
    "params": [
      {
        "script": {
            "code_hash": "0x00000000000000000000000000000000000000000000000000545950455f4944",
            "hash_type": "type",
            "args": "0x855508fe0f0ca25b935b070452ecaee48f6c9f1d66cd15f046616b99e948236a"
        },
        "script_type": "type"
      },
      "asc",
      "0x1"
    ]
  }'

Get the latest omnilock code cell on CKB testnet

curl --location --request POST 'https://testnet.ckb.dev/' \
  --header 'Content-Type: application/json' \
  --data-raw '{
    "id": 42,
    "jsonrpc": "2.0",
    "method": "get_cells",
    "params": [
      {
        "script": {
            "code_hash": "0x00000000000000000000000000000000000000000000000000545950455f4944",
            "hash_type": "type",
            "args": "0x761f51fc9cd6a504c32c6ae64b3746594d1af27629b427c5ccf6c9a725a89144"
        },
        "script_type": "type"
      },
      "asc",
      "0x1"
    ]
  }'

For following wallets:
* ethereum
* bitcoin
* tron
* dogecoin
@XuJiandong XuJiandong changed the title Update omni lock deployment information Update omni lock deployment and message signing message Jan 23, 2024
@XuJiandong XuJiandong changed the title Update omni lock deployment and message signing message Update omni lock deployment and message signing hash Feb 1, 2024
@XuJiandong XuJiandong changed the title Update omni lock deployment and message signing hash Update omni lock deployment and signing message hash Feb 1, 2024
@janx janx merged commit 79c3c06 into nervosnetwork:master Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants